Added support for multi root workspaces with the new language server server - #4244
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4244 +/- ##
========================================
+ Coverage 56% 78% +22%
========================================
Files 361 438 +77
Lines 15274 20390 +5116
Branches 2373 3273 +900
========================================
+ Hits 8494 15721 +7227
+ Misses 6236 4665 -1571
+ Partials 544 4 -540
|
Kartik Raj (karrtikr)
force-pushed
the
lsSupport
branch
4 times, most recently
from
February 1, 2019 00:57
c1cc3de to
1e77898
Compare
Kartik Raj (karrtikr)
changed the title
Kartik Raj (karrtikr)
force-pushed
the
lsSupport
branch
11 times, most recently
from
February 7, 2019 05:08
6a44a0b to
16f6d20
Compare
added 8 commits
February 11, 2019 15:13
Kartik Raj (karrtikr)
changed the title
Kartik Raj (karrtikr)
force-pushed
the
lsSupport
branch
from
February 12, 2019 03:02
bdf08fb to
e2ca8ea
Compare
Kartik Raj (karrtikr)
changed the title
Kartik Raj (karrtikr)
changed the title
Kartik Raj (karrtikr)
changed the title
Kartik Raj (karrtikr)
changed the title
Don Jayamanne (DonJayamanne)
requested changes
Feb 12, 2019
Don Jayamanne (DonJayamanne)
approved these changes
Feb 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3008
Test plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)